I have just tried to validate the front page of my Freeway and Expression Engine site digitalwatchlibrary.com using the W3C site. Initially it bought up many errors, most of my own doing but now I am down to 8 but for the life for me can’t work out what the are even though the validator is very helpful. If someone has the time could they have a quick look to see what I am doing wrong.
What an amazingly useful site. My main concern is that there is far too much going on! Too much to go wrong! Too much information to take in! As a graphic designer, I would prefer a much simpler front page, with fewer bells and whistles.Space is good, there is to much clutter, nowhere for the eye to rest. Your reference pages could use more of the space available too. It is a useful site though. Less is more!
Well done.
rogerjohn
On 6 Apr 2010, at 13:54, ummedia wrote:
I have just tried to validate the front page of my Freeway and Expression Engine site digitalwatchlibrary.com using the W3C site. Initially it bought up many errors, most of my own doing but now I am down to 8 but for the life for me can’t work out what the are even though the validator is very helpful. If someone has the time could they have a quick look to see what I am doing wrong.
Meaning all together that this is what it should look like:
<p class="f-lp"><a href="http://www.digitalwatchlibrary.com/DWL/1work/seiko_s229-5001/" title="ADD A TITLE HERE FOR YOUR LINKS"><img src="/images/watchlibrary/cache/s22950011_thumb-100x134.jpg" width="100" height="134" alt="SEIKO-S229-5001" class="centred" /></a></p>
You need to add a ‘title’ to your links for SEO purposes and you needed a closing:
</a>
tag to close the link or else anything under it would be linked.
Thanks for your help guys I’m down to 4 errors, so if you dont mind I’ll ask for a little more help. One of the errors was down to the imagesizer plugin stripping the out, this was easily resolved by moving out of the plugin.
Its complaining about this
end tag for element “P” which is not open
<p>You Need Flash!</p>
<!--[if !IE]>-->
</object>
<!--<![endif]-->
</object>
</div></p>
</div>
You have a div immediately inside a p, I’m pretty sure that’s where
you’re going awry. An object may be a direct child of a P, but a div
may not. So if you have a way to remove that generic div from around
the object tag, and just nest the object inside the p, then you should
be all right.
Most times with the validator, what looks like a lot of errors are
really only one or two root problems. Once you fix those, the rest
magically take care of themselves.
Walter
On Apr 6, 2010, at 12:39 PM, ummedia wrote:
Thanks for your help guys I’m down to 4 errors, so if you dont mind
I’ll ask for a little more help. One of the errors was down to the
imagesizer plugin stripping the out, this was easily resolved
by moving out of the plugin.
Its complaining about this
end tag for element “P” which is not open
<p>You Need Flash!</p>
<!--[if !IE]>-->
</object>
<!--<![endif]-->
</object>
Your code shows an opening p tag (the ‘class=“f-lp”’ one), then the
object tags. After the first ‘endif’ bit you have a ‘You Need Flash!’
message, which has it’s own set of p and /p tags.
Logically speaking, these are nested within the first p tag, which is
closed at the end just before the closing div tag.
But, programmatically speaking, it looks like the validator treats
the first closing /p tag as the end of the paragrah structure - and
then it wigs out when it finds another closing one.
Basically, it is incorrect to nest p tag structures. Even though
that’s inside a conditional statement the browser should only hit the
odd structure if it doesn’t have Flash installed, this would be a
validation problem.
Perhaps you can drop the p tags entirely from the ‘no Flash’ warning?
That’ll be within the main para structure anyway.
But also, how was that code produced? It wasn’t something Freeway
made all by itself, surely?
Keith its the standard code for the swfobject for flash I just
copied and pasted.
Copied and pasted from where? Into what, precisely?
end tag for element “P” which is not open
The only issue I can see with the code you posted is with the merging
of the two class names in the opening p tag, “style27” and “f-lp”. If
that’s not the cause of the error then it is down to something not in
this portion of code.
Keith it seemed to be the div tags inside the ps when I removed the divs, no more error. I havent made much of the code by hand just where I needed to input EE data.
Walter I removed the table and that solved the problem although there is probably a much nicer way to achieve that grid effect with divs.
Cant work out the maps as Freeway generated that html and I dont know how to change it.
Thank you everyone I’m not sure if this was the problem but I had the graphic link to an external url using EE code. I changed the graphic to a pass through and that seemed to do the trick(getting rid of the map), the fist page now passes validation. Hopefully they’ll be the same problems in the other pages so i’ll be able to sort them out. thank you to everyone for their help.
Well well, came home, and 17 replies to this post! @ummedia, you have gone through the same thing I experienced several times. This might happen if we combine EE tags, ‘hand-made’ code (read copy-and-past) and the code generated by FW. Point is, there is not so much control, and the avarage FW user is no hand-coder. I asked a few times questions at the EE forum, and sometimes I got the answer “those pesky HTML editors” meaning “you do not know what you’re doing.”
But, in the end, there is a site, made in Freeway, partly handcoded, partly filled with EE pieces, and it works. And it validates! So, be proud of your work. You learn a lot of this, the next pages will be a piece of cake. (sort of…
Thanks to all the help I had yesterday I have been a busy bee and been validating pages in lots of my sites most errors have been the same as yesterday but one I cam up against as an & in a external url I am calling at mals. I tried to url encode it with %26 but that didnt work. How should I do it or is it not possible.
many thanks
Adam
Did you know… White is the new Black and More is the new Less
